apache / apache/nuttx

CONFIG_CONSOLE_SYSLOG and CONFIG_SYSLOG_CONSOLE are misleading

Open
#12,767 2 comments 5 reactions 1 assignee Claimed by @raiden00pl View on GitHub
breaking change Type: Improvement
Dominant language
C
Stars
4k
Forks
1.7k
Avg merge
1d 17h
Merged PRs (30d)
237

Description

These options are misleading.

All other console enable options have the format like `CONFIG_{device_name}_CONSOLE`, but for SYSLOG it is `CONFIG_CONSOLE_SYSLOG`. Moreover there is `CONFIG_SYSLOG_CONSOLE` option but it has different purpose than other options with format `CONFIG_{device_name}_CONSOLE`.

```
config SYSLOG_CONSOLE
bool "Log to /dev/console"
default !ARCH_LOWPUTC && !SYSLOG_CHAR && !RAMLOG_SYSLOG && !SYSLOG_RPMSG && !SYSLOG_RTT
depends on DEV_CONSOLE
---help---
Use the system console as a SYSLOG output device.
```

```
config CONSOLE_SYSLOG
bool "Use SYSLOG for /dev/console"
default n
depends on DEV_CONSOLE && !SYSLOG_CONSOLE
---help---
Use the syslog logging device as a system console. If this feature is
enabled (along with DEV_CONSOLE), then all console output will be
re-directed to syslog output (syslog_putc). This is useful, for
example, if the only console is a Telnet console. Then in that case,
console output from non-Telnet threads will go to the syslog output.
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.