apache / apache/nuttx

There are many references to CONFIG_SPI_DMAPRIO in the kernel but it is not defined in none Kconfig or source file

Open
#11,932 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
4k
Forks
1.7k
Avg merge
1d 17h
Merged PRs (30d)
237

Description

I think a modification at some eons damaged few SPI drivers, there are references to CONFIG_SPI_DMAPRIO but without any definition of it.

I didn't investigate further, but probably some boards could be non-functional now.

```
$ git grep CONFIG_SPI_DMAPRIO
arch/arm/src/at32/at32_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/at32/at32_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/at32/at32_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32/stm32_i2s.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32/stm32_i2s.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32/stm32_i2s.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32/stm32_i2s.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32/stm32_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32/stm32_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32/stm32_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32/stm32_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32f0l0g0/stm32_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32f0l0g0/stm32_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32f0l0g0/stm32_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32f7/stm32_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32f7/stm32_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32f7/stm32_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32h7/stm32_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32h7/stm32_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32h7/stm32_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32h7/stm32_spi_slave.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32h7/stm32_spi_slave.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32h7/stm32_spi_slave.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32l4/stm32l4_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32l4/stm32l4_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32l4/stm32l4_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32l5/stm32l5_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32l5/stm32l5_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32l5/stm32l5_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32u5/stm32_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32u5/stm32_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32u5/stm32_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32wb/stm32wb_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32wb/stm32wb_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32wb/stm32wb_spi.c:# error "Illegal value for CONFIG_SPI_DMAPRIO"
arch/arm/src/stm32wl5/stm32wl5_spi.c:# if defined(CONFIG_SPI_DMAPRIO)
arch/arm/src/stm32wl5/stm32wl5_spi.c:# define SPI_DMA_PRIO CONFIG_SPI_DMAPRIO
arch/arm/src/stm32wl5/stm32wl5_spi.c:# error "Illegal value
```

Or maybe people started copying it blindly from stm32_spi.c. This is a point of attention. @raiden00pl did you notice it?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.