Error codes related to software flow control in file stm32_hciuart.c
- Dominant language
- C
- Stars
- 4k
- Forks
- 1.7k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 237
Description
These should be #ifdef instead of #ifndef：
https://github.com/apache/nuttx/blob/5adb9de00bc88ef34251fe02c783ec42e33d5bbb/arch/arm/src/stm32/stm32_hciuart.c#L243
https://github.com/apache/nuttx/blob/5adb9de00bc88ef34251fe02c783ec42e33d5bbb/arch/arm/src/stm32/stm32_hciuart.c#L269
https://github.com/apache/nuttx/blob/5adb9de00bc88ef34251fe02c783ec42e33d5bbb/arch/arm/src/stm32/stm32_hciuart.c#L1485
This:
https://github.com/apache/nuttx/blob/5adb9de00bc88ef34251fe02c783ec42e33d5bbb/arch/arm/src/stm32/stm32_hciuart.c#L988
https://github.com/apache/nuttx/blob/5adb9de00bc88ef34251fe02c783ec42e33d5bbb/arch/arm/src/stm32/stm32_hciuart.c#L990
should be :
` uint16_t inused = hciuart_rxinuse(config);`
` if (inused >= config->rxupper)`
This:
https://github.com/apache/nuttx/blob/5adb9de00bc88ef34251fe02c783ec42e33d5bbb/arch/arm/src/stm32/stm32_hciuart.c#L1025
should be :
` if (inused >= config->rxlower)`
This:
https://github.com/apache/nuttx/blob/5adb9de00bc88ef34251fe02c783ec42e33d5bbb/arch/arm/src/stm32/stm32_hciuart.c#L1616
should be :
` pinset = (config->rts_gpio & ~regval) | GPIO_OUTPUT | GPIO_OUTPUT_SET;`
Contributor guide
Assessment
This issue has not been assessed yet.