apache / apache/mynewt-nimble

Unify handling of disabled/enabled features

Open
#985 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
C
Stars
893
Forks
512
Avg merge
13d 31m
Merged PRs (30d)
7

Description

Currently (depending on feature) enabling/disabling is done by either compile time #ifdef, returning BLE_HS_ENOTSUP in runtime for disabled features, or by wrapping one feature on top of other API.

Runtime errors are not the best IMHO as those should be reserved for recoverable scenarios. I propose that we always do #ifdef so that application developer can detect mis-configuration at build time.

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue names no files, tests, or entry points. Begin by inventorying how features are currently enabled or disabled, then define the scope needed for all features to use compile-time #ifdef handling; done means misconfiguration is detected at build time rather than through runtime BLE_HS_ENOTSUP errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.