reserved identifier violation
- Dominant language
- C
- Stars
- 893
- Forks
- 512
- Avg merge
- 13d 31m
- Merged PRs (30d)
- 7
Description
I would like to point out that identifiers like “[`_MESH_GLUE_`](https://github.com/apache/mynewt-nimble/blob/10b3aa043ef7c2c023cd9418b5f35e40e07bb34f/nimble/host/mesh/include/mesh/glue.h#L20 "Update candidate")” and “[`__MODEL_CLI_H__`](https://github.com/apache/mynewt-nimble/blob/10b3aa043ef7c2c023cd9418b5f35e40e07bb34f/nimble/host/mesh/include/mesh/model_cli.h#L7 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the identifiers linked in nimble/host/mesh/include/mesh/glue.h at line 20 and nimble/host/mesh/include/mesh/model_cli.h at line 7. Check the surrounding header naming and references, then replace the reserved identifiers with unique non-reserved names and verify that the mesh code still builds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100