NLIP CRC is placed differently depending if receiving or sending?
- Dominant language
- C
- Stars
- 891
- Forks
- 381
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 14
Description
If I understand it correctly, the 16-bit NLIP CRC is placed differently depending if receiving or sending.
Just wanted to check if this is intentional? i.e. is it a feature or a bug? :)
Changing it would probably break things but current state also complicates how NLIP can be used.
https://github.com/apache/mynewt-core/blob/b65788b8422817d72bdbf06319bcf04a7f621cdf/sys/shell/src/shell_nlip.c#L106
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at sys/shell/src/shell_nlip.c around line 106 and trace how NLIP CRC placement differs between receiving and sending. Compare both paths and determine whether the difference is intentional or a compatibility bug; done means the behavior is explained and any required follow-up change is clearly identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100