apache / apache/mynewt-core

stats: `static STATS_NAME_START()` keeps static qualifier as is when statistics names are disabled

Open
#1,968 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
891
Forks
381
Avg merge
2d 7h
Merged PRs (30d)
14

Description

stats: `static STATS_NAME_START()` keeps static qualifier as is when statistics names are disabled.

There are couple of ways of solving this:
1. Remove static qualifier for all stat names
2. Add static qualifier to the macro and deal differently with it based on whether names are enabled or not

The above are just suggestions, there might be better ways of solving this.

Contributor guide

No contributing guide indexed for this repository

Research direction

No file or test is named in the issue. Locate the STATS_NAME_START macro and compare its expansion when statistics names are enabled versus disabled, then determine the intended handling of the static qualifier. Done means the disabled-names configuration produces a valid, consistent declaration without retaining an unintended static qualifier.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot, operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.