apache / apache/maven

[MNG-8092] Incorrect warning about building plugins with extensions as part of reactor

Open
#10,859 0 comments 0 reactions 0 assignees View on GitHub
bug priority:minor
Dominant language
Java
Stars
5.3k
Forks
3.1k
Avg merge
20h 42m
Merged PRs (30d)
297

Description

**[Daniel Puiu](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=JIRAUSER285001)** opened **[MNG-8092](https://issues.apache.org/jira/browse/MNG-8092?redirect=false)** and commented

The warning on building plugin extension as part of reactor is logged even when the plugin is excluded from the reactor using --projects/-pl.

https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java#L101 The method validateProjects is called on all collected projects before applying the filtering, so even when excluding the extension, the warn will still be printed.

I think the method (which only checks for this issue) could be easily renamed to validateExtensionIsNotPartOfReactor and be called on the filtered projects instead.

---

**Affects:** 3.9.6

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.