apache / apache/maven-wrapper

[MWRAPPER-122] Mingw paths problem on Windows

Open
#301 3 comments 0 reactions 0 assignees View on GitHub
bug priority:major
Dominant language
Java
Stars
254
Forks
78
Avg merge
5h 26m
Merged PRs (30d)
2

Description

**[Krystian Panek](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ciapunek)** opened **[MWRAPPER-122](https://issues.apache.org/jira/browse/MWRAPPER-122?redirect=false)** and commented

When I call the Maven wrapper from [Taskfile.dev](https://taskfile.dev/) then only on Windows in GitBash (on Mac and Linux works without problems) the following command is executed (I just replaced the last "exec" statement with "echo" to troubleshoot):

```java
/c/Program Files/Eclipse Adoptium/jdk-11.0.14.101-hotspot/bin/java -classpath C:\Projects\acme-aem-acme-mono-ad86003b367a/.mvn/wrapper/maven-wrapper.jar -Dmaven.multiModuleProjectDirectory=C:\Projects\acme-aem-acme-mono-ad86003b367a org.apache.maven.wrapper.MavenWrapperMain clean install -N
```

Note that **bad path separators are generated** and my task execution results in an error:

```java
task: [aem:build:root] sh mvnw clean install -N && mkdir -p target && touch target/done.txt
Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain
Caused by: java.lang.ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain
task: Failed to run task "aem:build:root": exit status 1
```

To fix the problem I needed to update the code:

```java
1. For Cygwin, switch paths to Windows format before running java
if $cygwin; then
```

to the following:

```java
1. For Cygwin or Mingw, switch paths to Windows format before running java
if [ "$cygwin" = true ] || [ "$mingw" = true ]; then
```

then I have a working exec command generated:

```java
/c/Program Files/Eclipse Adoptium/jdk-11.0.14.101-hotspot/bin/java -classpath /c/Projects/acme-aem-acme-mono-ad86003b367a/.mvn/wrapper/maven-wrapper.jar -Dmaven.multiModuleProjectDirectory=/c/Projects/acme-aem-acme-mono-ad86003b367a org.apache.maven.wrapper.MavenWrapperMain clean install -N
```

It would be nice to make the "mvnw script work in more use cases. by introducing the fix like the above or similar making my integration work without problems. 

 

Greetings, Krystian

---
No further details from [MWRAPPER-122](https://issues.apache.org/jira/browse/MWRAPPER-122?redirect=false)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.