apache / apache/maven-surefire
[SUREFIRE-1871] Usage of invalid XML tags
- Dominant language
- Java
- Stars
- 461
- Forks
- 588
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 19
Description
**[Andrea Stedile](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=steddy)** opened **[SUREFIRE-1871](https://issues.apache.org/jira/browse/SUREFIRE-1871?redirect=false)** and commented
To understand this issue, please, read my stackoverflow answer.
https://stackoverflow.com/a/65572096/14751136
This issue is related to the Maven Failsafe example (Using jetty and maven-failsafe-plugin):
https://maven.apache.org/surefire/maven-failsafe-plugin/usage.html:
Also, see the related issue, where I propose an update of jetty-maven-plugin to 11.
I think it should not be necessary to set **_daemon_** to true.
In facts, I do not see a reference to it in Jetty 9's programming guide.
https://www.eclipse.org/jetty/documentation/jetty-9/index.html
Search for the paragraph containing the following text:
_For example, you can configure the plugin to start your webapp at the beginning of your unit tests and stop at the end. To do this, you need to set up a couple of execution scenarios for the Jetty plugin. You use the pre-integration-test and post-integration-test Maven build phases to trigger the execution and termination of Jetty:_
That paragraph is the followed by the required code to do so, and the code doesn't mention _daemon_.
===> _Daemon_ is not even mentioned in Jetty 11, for which I proposed an update in a related issue.
https://www.eclipse.org/jetty/documentation/jetty-11/programming_guide.php
If we update to Jetty 11, _scanIntervalSeconds_ should be replaced with **_scan_**.
In Jetty 11 (latest) documentation:
https://www.eclipse.org/jetty/documentation/jetty-11/programming_guide.php
Search for the paragraph containing the following text:
_Here is an example, which turns on scanning for changes every ten seconds, and sets the webapp context path to /test_
And also for this one:
_Here’s an example of using the pre-integration-test and post-integration-test Maven build phases to trigger the execution and termination of Jetty:_
+You will see that, in both paragraphs, instead of using _scanIntervalSeconds_, _*scan*_ is used.+
---
**Affects:** 3.0.0-M5
Contributor guide
Research direction
Open the Maven Failsafe usage page referenced in the issue and compare its Jetty example with the linked Jetty 9 and Jetty 11 programming guides. Review the daemon and scanIntervalSeconds settings, then update the example to use the documented XML tags; done means the example matches the selected Jetty documentation without invalid tags.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100