apache / apache/maven-surefire

[SUREFIRE-2172] StringUtils: yet more of them

Open
#2,751 2 comments 0 reactions 0 assignees View on GitHub
enhancement priority:minor
Dominant language
Java
Stars
461
Forks
588
Avg merge
1d 8h
Merged PRs (30d)
19

Description

**[Elliotte Rusty Harold](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=elharo)** opened **[SUREFIRE-2172](https://issues.apache.org/jira/browse/SUREFIRE-2172?redirect=false)** and commented

This project contains not one, not two, but **three** different StringUtils classes that duplicate functionality in the JDK and elsewhere. One or two of them imght be built by shading other classes. They're even sometimes both imported in the same classes such as LegacyPojoStackTraceWriter:

import org.apache.maven.surefire.api.util.internal.StringUtils;

import static org.apache.maven.surefire.shared.utils.StringUtils.isNotEmpty;

Figure out what to do about this.

---

**Remote Links:**
- [GitHub Pull Request #768
](https://github.com/apache/maven-surefire/pull/768)

Contributor guide

Open the contributing guide

Research direction

Start by comparing the three StringUtils classes and their usages, including the conflicting imports in LegacyPojoStackTraceWriter. Review remote pull request #768 to understand work already attempted. Done would require a decided approach for the duplicate utilities and consistent updates across affected callers.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.