apache / apache/maven-shade-plugin

[MSHADE-196] Must not attempt to unzip unfamiliar dependency type

Open
#561 1 comment 0 reactions 0 assignees View on GitHub
bug priority:major
Dominant language
Java
Stars
188
Forks
103
Avg merge
16h 39m
Merged PRs (30d)
4

Description

**[Markus Karg](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mkarg)** opened **[MSHADE-196](https://issues.apache.org/jira/browse/MSHADE-196?redirect=false)** and commented

When adding dependencies to rather unconventional package types, like "dll" or "pdf", we noticed that the share plugin by default tries to unzip them. This is weird, as obviously this attempt will fail in almost any case. A user is forced to add explicit exceptions, which is tedious, error prone, and breaks CoC.

The solution is rather obvious: The shade plugin must only unzip those package types which it is familiar with. This namely is e. g. JAR, ZIP, BZIP, GZIP etc. but certainly not anything unknown.

The result of this change will be a simplification of the pom.xml, and shade plugin's behaviour will be more like a user expects it to work: Don't touch unkown stuff!

---

**Affects:** 2.3

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the shade plugin's dependency unpacking logic and existing tests for package-type handling. Reproduce the case with an unfamiliar dependency such as a DLL or PDF, then verify that recognized archive types are still unpacked while unknown types are left untouched.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.