apache / apache/maven-release

[MRELEASE-494] Should fail during release:prepare if scm:url doesn't match working copy

Open
#628 4 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
128
Forks
145
Avg merge
7h 7m
Merged PRs (30d)
3

Description

**[David M. Lee](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=leedm777)** opened **[MRELEASE-494](https://issues.apache.org/jira/browse/MRELEASE-494?redirect=false)** and commented

The release plugin should check scm:url against the output of `svn info`. If they don't match, it should fail with an error.

We had a situation where the pom file in a branch was screwed up during a merge, such that scm:url was incorrect. In our case, it pointed to the trunk instead of the branch.

This caused release:prepare to silently do the wrong thing. It would still do the normal edit/commit in the working copy of the branch, but then it would do the copy using the scm:url. In our case, this meant that the tag was copied from the trunk instead of the branch.

In fact, release:perform also completed successfully; our only indication that there was a problem was the version number of the released artifacts.

We cannot set remotetagging=false due to the Subversion bug trying to copy with svn > 1.5.

---

**Affects:** 2.0-beta-9

**Issue Links:**
- [MRELEASE-970](https://issues.apache.org/jira/browse/MRELEASE-970) Check that a pom.xml exists in the \\-folder
(_**"is duplicated by"**_)
- [MRELEASE-858](https://issues.apache.org/jira/browse/MRELEASE-858) Check if the SVN working copy URL matches connection URL
(_**"is duplicated by"**_)
- [SCM-741](https://issues.apache.org/jira/browse/SCM-741) scm:validate for svn should offer a way to check the current directory actually matches what's declared in the pom

- [MRELEASE-512](https://issues.apache.org/jira/browse/MRELEASE-512) SCM information should be validated

6 votes, 6 watchers

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.