apache / apache/maven-release

[MRELEASE-967] scmCommentPrefix is not used when tagging

Open
#1,132 5 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
128
Forks
145
Avg merge
7h 7m
Merged PRs (30d)
3

Description

**[Claus Nielsen](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=clausfod)** opened **[MRELEASE-967](https://issues.apache.org/jira/browse/MRELEASE-967?redirect=false)** and commented

We use a Jira Hook in out GIT installation to ensure a Jira Ticket in all commits. This is of course also activated when the release plugin comes into play.

When using release prepare with the scmCommentPrefix parameter, the commit message is not as expected when it comes to tagging. The initial prepare commit where the release version is committed works fine with the scmCommentPrefix, but in the next phase where the actual tagging is made the value in scmCommentPrefix is ignored. This result in a failing release with a lot of manual cleaning up in poms... :-(

I can see that there was a problem with this earlier before using scm api 1.3 and before the maven release version 2.0. But this should be fixed now.

Here is an example:
mvn release:prepare release:perform '-DscmCommentPrefix=NIS-145 NIS-295 (clausfod)' -Dresume=false '-Darguments=-DskipTests'

---

**Affects:** 2.5.3

**Attachments:**
- [mrp-git-jenkins.txt](https://issues.apache.org/jira/secure/attachment/12851945/mrp-git-jenkins.txt) (_3.14 kB_)
- [mrp-git-local.txt](https://issues.apache.org/jira/secure/attachment/12851946/mrp-git-local.txt) (_3.17 kB_)
- [mrp-test.zip](https://issues.apache.org/jira/secure/attachment/12852358/mrp-test.zip) (_5.34 kB_)

2 votes, 6 watchers

Contributor guide

No contributing guide indexed for this repository

Research direction

No source file or test is named. Reproduce the issue with the shown mvn release:prepare release:perform command and scmCommentPrefix value, then trace the tagging phase and compare its commit message with the initial prepare commit. Done means the prefix is preserved when creating the tag and the release completes without manual POM cleanup.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.