apache / apache/maven-plugin-tools

[MPLUGIN-504] [regression] Goal prefix is required now

Open
#803 12 comments 0 reactions 0 assignees View on GitHub
bug priority:major
Dominant language
Java
Stars
64
Forks
71
Avg merge
12h 24m
Merged PRs (30d)
32

Description

**[Christoph Läubrich](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=laeubi)** opened **[MPLUGIN-504](https://issues.apache.org/jira/browse/MPLUGIN-504?redirect=false)** and commented

With https://issues.apache.org/jira/browse/MPLUGIN-450 there was a regression introduced that leads to previous working builds fail if the have not configured a goalprefix, the error message is:

> You need to specify a goalPrefix as it can not be correctly computed

This has several issues:
1. It does not explain why one "needs" a goalPrefix, nor what it is useful for or why it can not be correctly computed.
2. It is effectively a breaking change in a minor version increment
3. The inital JIRA mentions that
a) in general, goal prefix is **+optional+**, but "good to have", and usually is present.
b) we may want to have some option to turn off this feature
4. Now it is required and there is no option to turn it off

Also the message is not true, the plugin has successfully computed a prefix before without any issues:
* If the artifact ends with -maven-plugin as in my-cool-maven-plugin the my-cool was chosen
* If the artifact ends with -plugin as in my-cool-plugin the my-cool was chosen
* otherwise the full artifact if was chosen as a prefix as in my-cool the my-cool was chosen

From a users point of view I don't see any problem or "disambiguates" with this approach that justifies a breaking change here, anyone who is concerned about not using this default can and already could choose a prefix and seem to been fine with it for a long time.

---

1 votes, 3 watchers

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.