apache / apache/maven-mvnd

The property of Environments with OptionType.VOID type cannot accept false value

Open
#720 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
3.5k
Forks
250
Avg merge
16h 22m
Merged PRs (30d)
36

Description

As discussed [here](https://github.com/apache/maven-mvnd/pull/719#issuecomment-1280155079), some properties like mvnd.rawStreams or mvnd.serial can not accept false value. This is caused by [[getCommandLineOption](https://github.com/apache/maven-mvnd/blob/5e59c404535ba21b925a372340c7b11749aa4050/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java#L425)] omit the following value, treat is as `true`. A proposal is to assign two OptionType forEnvironment, one for cli option, one for property.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in common/src/main/java/org/mvndaemon/mvnd/common/Environment.java at getCommandLineOption, then read the discussion in pull request 719. Trace how OptionType.VOID handles values for mvnd.rawStreams and mvnd.serial, and verify that an explicit false value is preserved rather than treated as true.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.