apache / apache/maven-invoker

[MSHARED-1041] Refactor: remove duplicate code, use addArg internally

Open
#142 3 comments 0 reactions 1 assignee Claimed by @slawekjaranowski View on GitHub
maintenance
Dominant language
Java
Stars
22
Forks
25
PR merge metrics
No merged PRs in 30d

Description

**[Slawomir Jaranowski](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=slawekjaranowski)** opened **[MSHARED-1041](https://issues.apache.org/jira/browse/MSHARED-1041?redirect=false)** and commented

We can replace methods like:

```java
public InvocationRequest setDebug( boolean debug )
{
this.debug = debug;
return this;
}
```

by

```java
public InvocationRequest setDebug( boolean debug )
{
if ( debug )
{
addArg( "-X" );
}
return this;

```

and simplify `MavenCommandLineBuilder`

---

**Issue Links:**
- [MSHARED-1019](https://issues.apache.org/jira/browse/MSHARED-1019) Allow pass raw cli option to Maven process

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.