apache / apache/maven-install-plugin

[MINSTALL-201] Regression in 3.1.2 when installing pom artifact

Open
#315 7 comments 0 reactions 0 assignees View on GitHub
bug priority:critical
Dominant language
Java
Stars
43
Forks
44
Avg merge
1d 23h
Merged PRs (30d)
11

Description

**[Christian Kohlschütter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ck@newsclub.de)** opened **[MINSTALL-201](https://issues.apache.org/jira/browse/MINSTALL-201?redirect=false)** and commented

With 3.1.2, I'm seeing wrong artifact metadata (POM files) being installed for POM-packaged artifacts in a multi-module project.

Prior to 3.1.2, we were excluding some operations in InstallMojo.java when a project's packaging was "pom". The check got removed, leading to ".pom" artifact files being installed as some sort of zip file (yet having the ".pom" file suffix).

This breaks all sorts of things for me, effectively rendering version 3.1.2 unusable.

Patch forthcoming.

To reproduce:

```java
git clone git@github.com:kohlschutter/kohlschutter-parent.git
git checkout kohlschutter-parent-1.7.2
cd kohlschutter-parent
mvn clean install -Dignorant -DskipTests
file $HOME/.m2/repository/com/kohlschutter/kohlschutter-parent-multirelease/1.7.2/kohlschutter-parent-multirelease-1.7.2.pom
1. the above command should return something like "XML 1.0 document text, ASCII text"

1. now change maven-install-plugin dependency version in kohlschutter-parent's pom.xml from 3.1.1 to 3.1.2
mvn clean install -Dignorant -DskipTests
file $HOME/.m2/repository/com/kohlschutter/kohlschutter-parent-multirelease/1.7.2/kohlschutter-parent-multirelease-1.7.2.pom

1. the above command now returns something like "Zip archive data, at least v1.0 to extract, compression method=store"

1. contents of the zip file:
1. META-INF/
1. META-INF/MANIFEST.MF
1. META-INF/maven/
1. META-INF/maven/com.kohlschutter/
1. META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/
1. META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/pom.xml
1. META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/pom.properties}}

```

---

**Affects:** 3.1.2

**Issue Links:**
- [MNG-8138](https://issues.apache.org/jira/browse/MNG-8138) Maven internal state should not allow to become "broken"
(_**"is caused by"**_)
- [MINSTALL-200](https://issues.apache.org/jira/browse/MINSTALL-200) "mvn jar:jar install:install" installs a jar instead of a pom

- [MINSTALL-189](https://issues.apache.org/jira/browse/MINSTALL-189) Add parameter to lax project validation

**Remote Links:**
- [GitHub Pull Request #72
](https://github.com/apache/maven-install-plugin/pull/72)

1 votes, 7 watchers

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.