apache / apache/maven-gpg-plugin
[MGPG-145] (IT suite) IT did not catch issue on Windows OS
- Dominant language
- Java
- Stars
- 31
- Forks
- 27
- Avg merge
- 4h 44m
- Merged PRs (30d)
- 4
Description
**[Tamas Cservenak](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cstamas)** opened **[MGPG-145](https://issues.apache.org/jira/browse/MGPG-145?redirect=false)** and commented
Since version 3.2.0 two things happened:
* we started terminating passphrase using "line separator" (as part of fix for MGPG-99)
* this caused that on Windows we corrupted passwords by extra "\r" present (see MGPG-136)
The problem we must fix: we DO have IT "sign-release-best-practices" and we have Windows in OS matrix, but this IT never failed, while user setup matrix did: https://github.com/ralfkonrad/test-mvn-gpg-plugin
WHY?
---
**Affects:** 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.5, 3.2.6
**Issue Links:**
- [MGPG-136](https://issues.apache.org/jira/browse/MGPG-136) "gpg: signing failed: Bad passphrase" on GitHub Windows runners
- [MGPG-99](https://issues.apache.org/jira/browse/MGPG-99) Passcode byte array provided to gpg executable on stdin is not terminated
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by examining the sign-release-best-practices integration test and its Windows entry in the OS matrix, then compare it with the user setup matrix in the linked test project. Trace why the Windows passphrase failure is not surfaced; done means the cause is understood and the integration coverage detects this regression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, ci-cd, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100