apache / apache/maven-checkstyle-plugin
DefaultCheckstyleExecutor should be a failure, not an error
- Dominant language
- Java
- Stars
- 97
- Forks
- 67
- Avg merge
- 14h 50m
- Merged PRs (30d)
- 6
Description
### Affected version
HEAD
### Bug description
Resolve this todo in DefaultCheckstyleExecutor
```
if (request.isFailsOnError()) {
// TODO: should be a failure, not an error. Report is not meant to
// throw an exception here (so site would
// work regardless of config), but should record this information
throw new CheckstyleExecutorException(message.toString());
}
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate DefaultCheckstyleExecutor and start at the TODO in the failsOnError branch. Trace how the report handles this condition and inspect nearby tests or test coverage for the executor. Done means the condition is recorded as a failure rather than raised as an error, while preserving the site behavior described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100