apache / apache/maven-checkstyle-plugin

[MCHECKSTYLE-351] Plugin execution fails on error when using google_checks

Open
#264 2 comments 0 reactions 0 assignees View on GitHub
bug priority:major
Dominant language
Java
Stars
97
Forks
67
Avg merge
14h 50m
Merged PRs (30d)
6

Description

**[Martin Schneider](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=martinschneider)** opened **[MCHECKSTYLE-351](https://issues.apache.org/jira/browse/MCHECKSTYLE-351?redirect=false)** and commented

 
I'm using the version 3.0.0 with Checkstyle 6.18.

This is my initial configuration:

```

org.apache.maven.plugins
 maven-checkstyle-plugin
${maven.checkstyle.plugin.version}

  true
true

```

Running `mvn checkstyle:checkstyle` will fail the build since there are checkstyle errors. This is expected. 

`[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (default-cli) on project demo: Failed during checkstyle execution: There are 311 errors reported by Checkstyle 6.18 with sun_checks.xml ruleset. -> [Help 1]`

However, when I use `google_checks.xml the build succeeds without any error (checkstyle-report.xml` still shows the issues).

 

```

org.apache.maven.plugins
 maven-checkstyle-plugin
${maven.checkstyle.plugin.version}

google_checks.xml
  true
true

```

 

My expectation would be that the build fails when I use the `google_checks.xml` configuration.

https://stackoverflow.com/questions/50040980/checkstyle-maven-plugin-doesnt-fail-on-error-when-using-google-checks

---
No further details from [MCHECKSTYLE-351](https://issues.apache.org/jira/browse/MCHECKSTYLE-351?redirect=false)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue with Maven Checkstyle Plugin 3.0.0 and Checkstyle 6.18 using the shown configuration, first with the default rules and then with google_checks.xml. Compare the build result with checkstyle-report.xml; done means violations using google_checks.xml cause the plugin execution to fail as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.