apache / apache/maven-checkstyle-plugin

Introduce parameter failOnMismatchedAllowedViolationsCount

Open
#174 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
97
Forks
67
Avg merge
14h 50m
Merged PRs (30d)
6

Description

### New feature, improvement proposal

Associated PR: https://github.com/apache/maven-checkstyle-plugin/pull/165

Introduce a parameter to fail the build when the number of violations is not equal to maxAllowedViolations

This prevents the following scenario:
- some changes reduce the checkstyle count but maxAllowedViolations is not updated
- some other changes introduces new violations but the build does not fail, as the count left some margin for error, when we would like to avoid introducing new failures

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the associated pull request at https://github.com/apache/maven-checkstyle-plugin/pull/165 to understand the proposed parameter and its current status. The change is done when the Maven Checkstyle Plugin can fail when the violation count differs from maxAllowedViolations, preventing both unreported new violations and an outdated allowance.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.