apache / apache/maven-assembly-plugin
AbstractAggregatingHandler is unfinished
- Dominant language
- Java
- Stars
- 110
- Forks
- 75
- Avg merge
- 12h 54m
- Merged PRs (30d)
- 10
Description
### Affected version
HEAD
### Bug description
resolve the FIXME one way or another
```
@Override
public void finalizeArchiveCreation(final Archiver archiver) {
// this will prompt the isSelected() call, below, for all resources added to the archive.
// FIXME: This needs to be corrected in the AbstractArchiver, where
// runArchiveFinalizers() is called before regular resources are added...
// which is done because the manifest needs to be added first, and the
// manifest-creation component is a finalizer in the assembly plugin...
for (final ResourceIterator it = archiver.getResources(); it.hasNext(); ) {
it.next();
}
addToArchive(archiver);
}
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with AbstractAggregatingHandler and the finalizeArchiveCreation method shown in the issue. Read AbstractArchiver and its runArchiveFinalizers flow, especially how the manifest-creation component is ordered relative to regular resources. Done means the FIXME is resolved without requiring the current resource iteration workaround, with relevant tests or assembly-plugin behavior confirming archive creation remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 42/100