apache / apache/maven-assembly-plugin

[MASSEMBLY-938] includeSubModules==false and useAllReactorProjects warning changes behaviour

Open
#1,147 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
110
Forks
75
Avg merge
12h 54m
Merged PRs (30d)
10

Description

**[Nigel Jones](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jonesn)** opened **[MASSEMBLY-938](https://issues.apache.org/jira/browse/MASSEMBLY-938?redirect=false)** and commented

The following moduleset fails to include the license and readme and reports '[WARNING] The following patterns were never triggered in this artifact inclusion filter: o 'org.odpi.egeria:egeria:*'

\
\
\true\
\
\
\
\
\org.odpi.egeria:egeria:*\
\
\
\false\
\
\
\/\
\
\NOTICE\
\LICENSE\
\truststore.p12\
\
\
\
\
\

Uncommenting '\false\' results in a warning :

15:48:20,349 [WARNING] includeSubModules == false is incompatible with useAllReactorProjects. Ignoring.

To refactor, remove the \ flag, and use the \ and \ sections to fine-tune the modules included.

However in this case there isn't a warning of a missing module AND the license/readme correctly gets included

Is this a bug? It appears to be, since the warning says 'Ignoring' so the result should be the same as if it wasn't specified?

In this particular case the module being referenced in this section is the top level pom (the ultimate parent of the module containing the assembly)

originally posted thread to: https://lists.apache.org/thread.html/rddcad12fa9403fe86c6d0c378dc91b3236eea5df1ce85bc27319b9bf%40%3Cusers.maven.apache.org%3E

---

**Affects:** 3.3.0

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the provided moduleSet with useAllReactorProjects enabled, comparing behavior with includeSubModules omitted versus set to false. Inspect the module-set handling and warning path to determine why the top-level parent artifact and LICENSE/NOTICE files are treated differently. Done means the warning's stated behavior matches the resulting artifact inclusion, with coverage for this configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.