[MASSEMBLY-906] moduleSet doesn't recognize sources identifier

**[Norbert Kalmár](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=nkalmar)** opened **[MASSEMBLY-906](https://issues.apache.org/jira/browse/MASSEMBLY-906?redirect=false)** and commented

I tried adding the sources jar to a tar.gz tarball. I have a separate module for assembly. It is built last. Source jars are built for every module.
I tried every possible identifier I could come up with, like:

```xml
org.apache.zookeeper:zookeeper-server:*:*:*
org.apache.zookeeper:zookeeper-server:jar:sources:${project.version}
org.apache.zookeeper:zookeeper-server:jar:*:*
org.apache.zookeeper:zookeeper-server:*:*
```

And different combinations of these.
Every time I got the warning:

```
The following patterns were never triggered in this artifact inclusion filter:
```

The assembly module is dependent on the module that has the source jar.
I also tried adding it to be explicitly depend on the source of the module.

Here is the PR for the whole change if additional information is needed:
https://github.com/apache/zookeeper/pull/828

As a workaround I just used fileset to include the sources jar.

Thanks!

---
No further details from [MASSEMBLY-906](https://issues.apache.org/jira/browse/MASSEMBLY-906?redirect=false)

Start by reproducing the assembly moduleSet configuration with the source-jar identifiers shown in the report, then compare its behavior with the fileset workaround. Done means a sources jar is included in the tar.gz archive through moduleSet without the “patterns were never triggered” warning.

Written by the indexing model from the issue text.