apache / apache/maka

fix(desktop): route Rive diagnostics through the core secret redactor

Open
#4,925 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
5.4k
Forks
502
Avg merge
1d 2h
Merged PRs (30d)
715

Description

## Problem

`apps/desktop/src/main/rive-cli.ts` maintains a private `redactRiveText` implementation alongside the authoritative `@maka/core/redaction` rules. The local copy only recognizes a small set of bearer, `sk-`, and key/value patterns, so newly supported credentials such as GitHub, Google, or Slack tokens can be emitted in Rive diagnostics and tool output.

## Scope

- Make the core redactor the single source of truth for Rive stdout/stderr tails, error envelopes, command display, and structured values.
- Keep the existing deep-value traversal and maximum-depth guard, and preserve the current Rive helper exports where callers use them.
- Keep the command protocol and result shape unchanged.

## Acceptance criteria

- Rive output and error projections never expose core-supported token forms or sensitive keyed values.
- Nested arrays/objects remain bounded by the existing depth policy.
- Existing Rive workflow tests pass, with regression coverage for at least one token form that the local implementation missed.

This is the Rive redaction slice of #1404.

Contributor guide

Open the contributing guide

Research direction

Start with apps/desktop/src/main/rive-cli.ts and the authoritative @maka/core/redaction rules; trace how Rive stdout/stderr, errors, command display, and structured values are projected. Preserve the existing deep traversal, depth guard, helper exports, protocol, and result shape, then add regression coverage for a token form the local implementation missed and run the existing Rive workflow tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.