Remove Fields Order Checks from CheckIndex? [LUCENE-8924]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
CheckIndex checks the order of fields read from the FieldsEnum for the posting reader. Since we do not explicitly sort or use a sorted data structure to represent keys (atleast explicitly), and no FieldsEnum depends on the order apart from MultiFieldsEnum, which no longer exists.
Should we remove the check?
---
Migrated from [LUCENE-8924](https://issues.apache.org/jira/browse/LUCENE-8924) by Atri Sharma (@atris)
Contributor guide
Research direction
Start at CheckIndex's fields-order validation and trace the FieldsEnum implementations used by the posting reader, checking whether any current implementation relies on ordering. The issue is complete when the dependency question is resolved and the check's removal or retention is supported by appropriate verification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100