apache / apache/lucene

Add State To QueryVisitor [LUCENE-8882]

Open
#9,925 3 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

QueryVisitor has no state passed in either up or down recursion. This limits the width of decisions that can be taken by visitation of QueryVisitor. For eg, for #9924, we need a way to specify is the visitor is a rewriter visitor.

 

This Jira proposes adding a property bag model to QueryVisitor, which can then be referred to by the Query instance being visited by QueryVisitor.

---
Migrated from [LUCENE-8882](https://issues.apache.org/jira/browse/LUCENE-8882) by Atri Sharma (@atris), updated Jul 02 2019

Contributor guide

Open the contributing guide

Research direction

Start by reading QueryVisitor and the Query implementations involved in visitation, then review issue #9924 and the linked LUCENE-8882 proposal for the required visitor context. Define how a property-bag state moves through recursion and is exposed to the visited Query; done means the rewriter-visitor use case can access that state during visitation.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.