Query.rewrite Should Move To QueryVisitor [LUCENE-8881]
Open
legacy-jira-priority:Major
type:enhancement
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
Now that we have QueryVisitor, the rewrite functionality should belong there, since rewrite is essentially a recursive visitation of underlying queries, which sounds exactly as what QueryVisitor is designed to be.
---
Migrated from [LUCENE-8881](https://issues.apache.org/jira/browse/LUCENE-8881) by Atri Sharma (@atris), updated Jun 27 2019
Contributor guide
Research direction
Start with Query.rewrite and QueryVisitor, then trace how rewrite recursively visits underlying queries. Done means the rewrite functionality is moved to QueryVisitor while preserving its intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100