apache / apache/lucene

lucene/queryparser DOMUtils.getAttributeOrFail(Element,String) never fails [LUCENE-8743]

Open
#9,788 2 comments 0 reactions 1 assignee Claimed by @cpoerschke View on GitHub
legacy-jira-priority:Minor type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

https://docs.oracle.com/javase/8/docs/api/org/w3c/dom/Element.html#getAttribute-java.lang.String- describes the `Element.getAttribute` return value as "The Attr value as a string, or the empty string if that attribute does not have a specified or default value." but `DOMUtils.getAttributeOrFail` only checks for `null` and so it never fails.

---
Migrated from [LUCENE-8743](https://issues.apache.org/jira/browse/LUCENE-8743) by Christine Poerschke (@cpoerschke), updated Jun 14 2019
Attachments: [LUCENE-8743.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-8743/LUCENE-8743.patch)
Linked issues:
- #9787

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.