apache / apache/lucene

Simplify relate logic on EdgeTree [LUCENE-8722]

Open
#9,768 1 comment 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Trivial type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

Currently Edge tree contains three methods for `relate`: relate, internalComponentRelate and componentRelate.

`internalComponentRelate` does not bring any benefit and it is trivial to merge the logic it contains into the `relate` method.

---
Migrated from [LUCENE-8722](https://issues.apache.org/jira/browse/LUCENE-8722) by Ignacio Vera (@iverase), updated Mar 13 2019
Attachments: [LUCENE-8722.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-8722/LUCENE-8722.patch)

Contributor guide

Open the contributing guide

Research direction

Locate EdgeTree and compare its relate, internalComponentRelate, and componentRelate methods; the linked LUCENE-8722.patch provides additional context. Done means the internalComponentRelate logic is merged into relate without changing behavior, with the relevant existing tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.