Synchronize JavaCC tasks with actual Java code [LUCENE-8683]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
##### Changes list:
1. Apply [SOLR-11662](https://issues.apache.org/jira/browse/SOLR-11662) changes back to Solr QueryParser.jj
1. Move jj_3R_7 method in Solr QueryParser.java back to generated position after [SOLR-9185](https://issues.apache.org/jira/browse/SOLR-9185) merge.
1. Incorporate deprecated methods removal in CharStream by [SOLR-8764](https://issues.apache.org/jira/browse/SOLR-8764) to ant build via regexps.
1. Incorporate unused imports removal by #8373 to ant build via regexps.
1. Remove unused import from Lucene surround/parser/QueryParser.jj
1. Move license header from PARSER_BEGIN/PARSER_END block in Lucene flexible/standard/parser/StandardSyntaxParser.jj
1. Update JavaCC's OriginalChecksum lines to actual for Lucene flexible standard parser utility classes.
##### Cumulative effect of this patch:
- Actual query parsing code remains unchanged.
- ant javacc (both lucene/queryparser and solr/core) now left source tree intact.
##### Final thoughts:
- I’m not very happy with this tricky regexp replacements, maybe we should pick some special tool for sources postprocessing.
- It will be great to develop a special precommit task to ensure metasource and source consistency.
Patch removing Lucene CharStream deprecated methods extracted to sub-task for master branch only.
---
Migrated from [LUCENE-8683](https://issues.apache.org/jira/browse/LUCENE-8683) by Nikolay Khitrin (@khitrin)
Attachments: [LUCENE-8683.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-8683/LUCENE-8683.patch)
Sub-tasks:
- #9730
Contributor guide
Assessment
This issue has not been assessed yet.