apache / apache/lucene

Improve accuracy of distance query for Geo3DPoint [LUCENE-8577]

Open
#9,623 0 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major module:spatial3d type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

The distance query for Geo3DPoint currently uses the GeoStandardCircle which is only accurate when the PlanetModel is a sphere.

In #9019. a new implementation called GeoExactCircle was added that models an exact circle, even when the planet model is not a sphere. Because Geo3DPoint is using WGS84 planet model, we should be using this implementation instead. The downside is that this implementation will be slightly slower.

---
Migrated from [LUCENE-8577](https://issues.apache.org/jira/browse/LUCENE-8577) by Ignacio Vera (@iverase)

Contributor guide

Open the contributing guide

Research direction

Start by locating the Geo3DPoint distance-query code and compare its use of GeoStandardCircle with the GeoExactCircle implementation introduced in #9019. Confirm the behavior for the WGS84 PlanetModel and verify that the query uses the exact-circle behavior, including any relevant existing tests or accuracy checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.