apache / apache/lucene

Make ConjunctionSpans protected/public [LUCENE-8426]

Open
#9,472 2 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major module:core/search type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

ConjunctionSpans is currently package-private. This means if I want to write a custom Spans implementation that can use it, I need to basically copy the class. If there is not good reason to keep it restricted to package, I would like to make it protected, or even public.

---
Migrated from [LUCENE-8426](https://issues.apache.org/jira/browse/LUCENE-8426) by Hari Menon (@hshankar), 1 vote

Contributor guide

Open the contributing guide

Research direction

Start by locating the ConjunctionSpans class and reviewing its callers and surrounding Spans API. Confirm with maintainers whether protected or public visibility is intended, then update the visibility and verify that the relevant API checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.