apache / apache/lucene

Fix regenerate tasks to reproduce files with UNIX line endings by default [LUCENE-8225]

Open
#9,272 0 comments 0 reactions 1 assignee Claimed by @uschindler View on GitHub
legacy-jira-priority:Major type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

The ant generate tasks currently always normalize line endings to the local conventions. This was required by Subversion. With GIT it depends on your local config, but we should really use unix endings by default (don't use autofix crlf on windows, as this breaks shell/cmd scripts).

The idea is:
- add a property which defaults to "UNIX"
- fix the CRLF tasks in ant's build to use it

If somebody really wants to use Git's autofixing, he needs to change the property in his lucene.build.properties.

---
Migrated from [LUCENE-8225](https://issues.apache.org/jira/browse/LUCENE-8225) by Uwe Schindler (@uschindler)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.