Precommit should fail on synchronization over non-final member variable [LUCENE-8172]
Open
legacy-jira-priority:Minor
type:enhancement
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
Precommit should fail over synchronization over a non-final member variable such as in https://issues.apache.org/jira/browse/SOLR-11980. Because the value can change, it shouldn't be synchronized over. Chances are the declaration should have final but is missing it.
---
Migrated from [LUCENE-8172](https://issues.apache.org/jira/browse/LUCENE-8172) by Michael Braun (@michaelbraun)
Contributor guide
Research direction
Start by locating Lucene's precommit checks and the existing synchronization-related validation. Determine how that check identifies synchronized access to non-final member variables, then run the relevant precommit tests; done means such synchronization is rejected while valid synchronization still passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100