precommit should fail the build if any jar sha1 files contain any whitespace or newlines [LUCENE-7949]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
as part of [SOLR-11209](https://issues.apache.org/jira/browse/SOLR-11209), miller updated the sha1 files for the jar's he was upgrading, and somehow a trailing newline got added to one of them, which caused jenkins to freak out about modified source files as part of the build (IIUC because jenkins was rebuilding the sha files and noticing they were different – just because of the trailing newline.
If precommit validated/enforced the expected structure of the sha1 files we could prevent these types of confusing build failures down the road.
---
Migrated from [LUCENE-7949](https://issues.apache.org/jira/browse/LUCENE-7949) by Chris M. Hostetter (@hossman), updated Sep 07 2017
Linked issues:
- [SOLR-11241](https://issues.apache.org/jira/browse/SOLR-11241)
- [SOLR-11209](https://issues.apache.org/jira/browse/SOLR-11209)
Contributor guide
Research direction
Start by tracing the precommit checks that process jar SHA1 files and identify where their structure is validated. Done means a SHA1 file containing whitespace or a newline causes precommit to fail clearly, preventing later build failures from modified checksum files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100