PackedQuadCell need not eagerly pre-compute the term bytes [LUCENE-7860]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
PackedQuadCell is eagerly computing the term bytes, and I don't think it should bother – it might not even be used. It also extends LegacyCell, which it needn't; it has legacy baggage and term bytes that can be omitted.
---
Migrated from [LUCENE-7860](https://issues.apache.org/jira/browse/LUCENE-7860) by David Smiley (@dsmiley)
Attachments: [LUCENE_7860__PackedQuadCell_refactor.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-7860/LUCENE_7860__PackedQuadCell_refactor.patch)
Contributor guide
Research direction
Start by locating PackedQuadCell and LegacyCell in the Lucene source and read how PackedQuadCell computes its term bytes and inherits from LegacyCell. Compare the behavior with the attached LUCENE_7860__PackedQuadCell_refactor.patch. Done means PackedQuadCell no longer eagerly computes unused term bytes or carries unnecessary legacy inheritance, with relevant existing tests still passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100