apache / apache/lucene

consider to remove DocSet.close() [LUCENE-7516]

Open
#8,567 2 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Trivial type:task
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

@romseygeek, I'd like to do the subj but I've found

```Java
/** FUTURE: for off-heap */
`@Override`
public void close() throws IOException {
}
```

and want to sync up with @yonik. If he confirm, let's nuke it from master, keeping in 6x as well it's public method. it should be SOLR ticket for sure

---
Migrated from [LUCENE-7516](https://issues.apache.org/jira/browse/LUCENE-7516) by Mikhail Khludnev (@mkhludnev), updated Oct 22 2016
Parent: #8563

Contributor guide

Open the contributing guide

Research direction

Start by locating DocSet.close() and reviewing parent issue #8563 and the referenced LUCENE-7516 context. Confirm with the mentioned maintainers whether it should be removed from master while retained in 6.x, and coordinate the Solr ticket; done means the agreed API changes are reflected without breaking callers.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.