apache / apache/lucene

fix random number generation used for spatial tests [LUCENE-7185]

Open
#8,240 27 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

The current method is not very good for testing.

- It will only rarely or never return edge cases like -180/180/-90/90
- It will only rarely return 0
- There are many possible doubles within the ranges (-180..180/-90..90) it will never return

---
Migrated from [LUCENE-7185](https://issues.apache.org/jira/browse/LUCENE-7185) by Robert Muir (@rmuir), updated Apr 18 2016
Attachments: [LUCENE-7185_polygon.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-7185/LUCENE-7185_polygon.patch), [LUCENE-7185_sorting.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-7185/LUCENE-7185_sorting.patch), [LUCENE-7185.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-7185/LUCENE-7185.patch), [newRandom.png](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-7185/newRandom.png), [oldRandom.png](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-7185/oldRandom.png)

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the attached LUCENE-7185.patch, LUCENE-7185_polygon.patch, LUCENE-7185_sorting.patch, and the newRandom.png/oldRandom.png comparisons to locate the spatial-test random-number method. Done means the generator can produce boundary values, zero, and a broader range of doubles within the longitude and latitude limits.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.