Add clean as a dependency on precommit [LUCENE-6728]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
I think that precommit should depend on clean. On branch_5x, I started a precommit, then realized partway through that I was running with Java 8. I interrupted the precommit, changed JAVA_HOME to point at Java 7, and started it again. After a few minutes, the forbidden-api check failed because it couldn't find a class.
Is there any situation where a clean should NOT be done before starting precommit?
---
Migrated from [LUCENE-6728](https://issues.apache.org/jira/browse/LUCENE-6728) by Shawn Heisey (@elyograg), updated Mar 07 2018
Contributor guide
Research direction
Start by inspecting the precommit and clean build targets on branch_5x, then trace the forbidden-api check that failed after switching Java versions. Determine whether precommit should invoke clean and verify the resulting behavior with the relevant build checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100