Is it ok for IndexWriter.prepareCommit to be an NRT-visible change? [LUCENE-6565]
Open
legacy-jira-priority:Major
type:task
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
Because of #7581, IndexWriter.prepareCommit is now an NRT-visible change. For instance the following test would fail:
```Java
Directory dir = newDirectory();
IndexWriter w = new IndexWriter(dir, new IndexWriterConfig(new MockAnalyzer(random())));
w.addDocument(new Document());
DirectoryReader reader = DirectoryReader.open(w, true);
assertNull(DirectoryReader.openIfChanged(reader)); // ok
w.prepareCommit();
assertNull(DirectoryReader.openIfChanged(reader)); // fails
```
---
Migrated from [LUCENE-6565](https://issues.apache.org/jira/browse/LUCENE-6565) by Adrien Grand (@jpountz), updated Jun 20 2015
Contributor guide
Assessment
This issue has not been assessed yet.