apache / apache/lucene

WeightedSpansTermExtractor has a broken IndexReader [LUCENE-6390]

Open
#7,450 6 comments 0 reactions 0 assignees View on GitHub
legacy-jira-fix-version:5.2 legacy-jira-fix-version:6.0 legacy-jira-priority:Critical type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

The DelegatingLeafReader there is broken, it does not implement getFieldInfos. This is not an optional method, and this is blocking performance improvements to spans.

I'm gonna work around it for now, but if it won't be fixed, then this DelegatingLeafReader optimization should be removed.

---
Migrated from [LUCENE-6390](https://issues.apache.org/jira/browse/LUCENE-6390) by Robert Muir (@rmuir), updated May 09 2016

Contributor guide

Open the contributing guide

Research direction

Start by locating DelegatingLeafReader and inspect how WeightedSpansTermExtractor uses it. Verify the IndexReader contract around getFieldInfos and examine the existing workaround mentioned in the issue. Done means DelegatingLeafReader correctly implements getFieldInfos and the spans-related behavior no longer encounters a broken reader.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.