apache / apache/lucene

fix or remove ecj linter, jtidy, etc? [LUCENE-6230]

Open
#7,292 1 comment 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

We now have doclint running on compile/javadoc to find problems. Can we remove some extra linters?

Jtidy: this consumes a ton of memory, and doesn't have good error messages. Can we just remove it in trunk at least?

ECJ: this is slow, unless we upgrade minimum ant version from 1.8.2 to 1.8.3, then we can make it _really_ not generate .class files, because the javac task has a createMissingPackageInfoClass we can disable. alternatively, we could also remove this checker. I am unsure if its providing anything beyond doclint.

---
Migrated from [LUCENE-6230](https://issues.apache.org/jira/browse/LUCENE-6230) by Robert Muir (@rmuir)
Attachments: [LUCENE-6230_fix_ecj_increase_ant.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-6230/LUCENE-6230_fix_ecj_increase_ant.patch)

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the build configuration for the compile/javadoc doclint task and the Jtidy and ECJ checks described in the issue. Read the attached LUCENE-6230_fix_ecj_increase_ant.patch for prior context, then compare what each checker still reports beyond doclint. Done means an agreed decision is implemented and the build remains passing without unnecessary checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.