Remove Scorer.getChildren? [LUCENE-6229]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
This API is used in a single place in our code base: ToParentBlockJoinCollector. In addition, the usage is a bit buggy given that using this API from a collector only works if setScorer is called with an actual Scorer (and not eg. FakeScorer or BooleanScorer like you would get in disjunctions) so it needs a custom IndexSearcher that does not use the BulkScorer API.
---
Migrated from [LUCENE-6229](https://issues.apache.org/jira/browse/LUCENE-6229) by Adrien Grand (@jpountz), updated Mar 27 2019
Linked issues:
- #8016
- #8679
- [SOLR-8643](https://issues.apache.org/jira/browse/SOLR-8643)
Contributor guide
Research direction
Start by tracing Scorer.getChildren and its sole reported use in ToParentBlockJoinCollector. Read the linked issues for current context, then inspect how IndexSearcher and BulkScorer affect scorer types and determine the intended removal or replacement. Done means the obsolete API and its usage are resolved without the reported collector and disjunction problems.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, search
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100