spatial PrefixTree based filters should use BitDocIdSet.Builder instead of direct impls [LUCENE-6186]
Open
legacy-jira-priority:Minor
module:spatial
type:enhancement
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
Intersects and Within reference FixedBitSet, Contains has a custom SmallDocSet. These should be modified to use BitDocIdSet.Builder for better memory use in sparse cases, and it'll be less code for Contains as well.
---
Migrated from [LUCENE-6186](https://issues.apache.org/jira/browse/LUCENE-6186) by David Smiley (@dsmiley)
Contributor guide
Research direction
Locate the spatial PrefixTree filter implementations for Intersects, Within, and Contains, then inspect how they currently use FixedBitSet and the custom SmallDocSet. Compare those paths with BitDocIdSet.Builder and update the direct implementations so sparse cases use the builder and Contains no longer needs its custom set.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100