nuke FilterDirectory.unwrap or make package-private [LUCENE-6154]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
As Uwe points out, this is dangerous. The only thing using it is its test: TestFilterDirectory.testUnwrap() and IOUtils.spins().
If this method is implemented in some other way, we could remove it. otherwise maybe it can be package-private.
---
Migrated from [LUCENE-6154](https://issues.apache.org/jira/browse/LUCENE-6154) by Robert Muir (@rmuir), updated Jan 01 2015
Linked issues:
- #5811
Contributor guide
Research direction
Start by locating FilterDirectory.unwrap and its named callers, TestFilterDirectory.testUnwrap() and IOUtils.spins(). Read those usages and the related test to determine whether the method can be removed or should become package-private. Done means the chosen visibility or removal is implemented and the affected tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100