apache / apache/lucene

move libversions check out of precommit to another target? [LUCENE-6018]

Open
#7,080 3 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

The libversions check can be especially heavy (taking minutes and downloading a lot?). Lately, i cannot get it to finish. To run precommit checks i have to hack build.xml and then revert it.

Can we move this from precommit to another target? A few things:
1. i dont think most commits contain changes to third party dependencies, so it discourages precommit, which is already hard to get people to run.
2. most commits that DO contain changes to third party dependencies, the people committing them don't run precommit before doing so. We know this from the jenkins fails that happen.
3. really, for a "packaging" change like dependencies nightly-smoke is the one to run to get best verification.

We should do the same for other problematic targets, I know i opened an issue for the jtidy one... that is still unresolved.

---
Migrated from [LUCENE-6018](https://issues.apache.org/jira/browse/LUCENE-6018) by Robert Muir (@rmuir)

Contributor guide

Open the contributing guide

Research direction

Start in build.xml by locating the precommit target and its libversions check, then inspect the nightly-smoke target and the Jenkins failures described in the issue. Determine where the check should run instead; done means ordinary precommit no longer performs the heavy check while dependency changes still receive the intended verification.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, ci-cd
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.