3.x back compat in SegmentInfos.write is too risky/complex [LUCENE-5942]
Open
legacy-jira-priority:Major
type:bug
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
I can't tell if the right files are being fsynced/deleted, e.g. there is segmentFileName vs segmentsFileName and too much nested exception handling.
Can someone refactor the 3.x logic? Otherwise in 72 hours, i plan to remove support for 3.x in this file.
---
Migrated from [LUCENE-5942](https://issues.apache.org/jira/browse/LUCENE-5942) by Robert Muir (@rmuir)
Contributor guide
Research direction
The issue points to SegmentInfos.write but does not name its file or a test. Start by locating that method and tracing the 3.x compatibility path, especially fsync/delete handling and nested exceptions. Done means the compatibility logic has a clear, verified refactoring, or the proposed removal of 3.x support is explicitly carried out.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100