apache / apache/lucene

Make all resourceDescriptions of indexinputs consistent [LUCENE-5726]

Open
#6,788 1 comment 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

This was weakly tested in a roundabout way by an assert that tried to read a lucene 2.x index.

We should try to make these consistent, on the other hand we should be careful about keeping the overhead of slice() relatively low (it would be nice to use this api in more places).

And such things should be tested elsewhere, e.g. BaseDirectoryTestCase

---
Migrated from [LUCENE-5726](https://issues.apache.org/jira/browse/LUCENE-5726) by Robert Muir (@rmuir)

Contributor guide

Open the contributing guide

Research direction

Start by locating the index input implementations that expose resourceDescriptions and use slice(), then inspect BaseDirectoryTestCase for the suggested coverage. Compare the resource descriptions across implementations and add tests showing consistent behavior while preserving the stated low overhead of slice().

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.